Skip to content

Keep regex search working without native PCRE2 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel-Darbord merged 4 commits into from
Jul 18, 2026
Merged

Keep regex search working without native PCRE2 #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9345f20
Make PCRE2 an optional runtime enhancement
Gabriel-Darbord Jul 17, 2026
ab591de
Keep PCRE2 as a loaded dependency
Gabriel-Darbord Jul 17, 2026
8a7dd53
Keep native PCRE2 fallback test focused
Gabriel-Darbord Jul 17, 2026
f9d9c7c
Use PCRE2 native-library availability probe
Gabriel-Darbord Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions src/MCP-Tests/MCPToolMethodSearchTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,6 @@ MCPToolMethodSearchTest >> targetClassName [
^ 'MCPToolMethodSearchTestTarget'
]

{ #category : 'tests' }
MCPToolMethodSearchTest >> testBasicRegexMatcherRemainsAvailableAsFallback [

| matcher tool |
tool := MCPToolSearchMethodMetadata new.
matcher := tool
basicRegexMatcherForPattern: 'MCP.*Test'
caseSensitive: true.
self assert: (matcher value: 'MCPToolMethodSearchTest').
self deny: (matcher value: 'mcpToolMethodSearchTest')
]

{ #category : 'tests' }
MCPToolMethodSearchTest >> testCanFilterAcrossExplicitProtocolTarget [

Expand Down Expand Up @@ -704,6 +692,16 @@ MCPToolMethodSearchTest >> testParentClassNamesReturnParentMethods [
in: (data at: #methods)
]

{ #category : 'tests' }
MCPToolMethodSearchTest >> testRegexMatcherUsesBasicRegexWhenPCRE2Unavailable [

| matcher tool |
tool := MCPToolSearchWithoutPCRE2TestStub new.
matcher := tool regexMatcherForPattern: 'MCP.*Test' caseSensitive: true.
self assert: (matcher value: 'MCPToolMethodSearchTest').
self deny: (matcher value: 'mcpToolMethodSearchTest')
]

{ #category : 'tests' }
MCPToolMethodSearchTest >> testRegexMatcherUsesPCRE2WhenLibraryAvailable [

Expand Down
22 changes: 22 additions & 0 deletions src/MCP-Tests/MCPToolSearchWithoutPCRE2TestStub.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
"
Test tool that models an unavailable native PCRE2 library.
"
Class {
#name : 'MCPToolSearchWithoutPCRE2TestStub',
#superclass : 'MCPToolSearchMethodMetadata',
#category : 'MCP-Tests-Support',
#package : 'MCP-Tests',
#tag : 'Support'
}

{ #category : 'testing' }
MCPToolSearchWithoutPCRE2TestStub class >> isAbstract [

^ true
]

{ #category : 'testing' }
MCPToolSearchWithoutPCRE2TestStub >> pcre2RegexLibraryAvailable [

^ false
]
9 changes: 2 additions & 7 deletions src/MCP/MCPToolSearch.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,7 @@ MCPToolSearch >> includeSourceSchemaPropertyWithDescription: includeSourceDescri
{ #category : 'private - results' }
MCPToolSearch >> isRegexSyntaxError: anError [

^ anError class = RegexSyntaxError or: [
anError class = PCRE2CompileError ]
^ anError class = RegexSyntaxError or: [ anError class = PCRE2CompileError ]
]

{ #category : 'private - template' }
Expand Down Expand Up @@ -437,11 +436,7 @@ MCPToolSearch >> parsedRequestFromToolRequest: request [
MCPToolSearch >> pcre2RegexLibraryAvailable [
"PCRE2 is an optional native runtime dependency: the Smalltalk package can be loaded while the host library is missing."

^ [
LibPCRE2UTF8 config: PCRE2 configVersion.
true ]
on: Error
do: [ false ]
^ LibPCRE2UTF8 isNativeLibraryAvailable
]

{ #category : 'private - filtering' }
Expand Down
Loading