Skip to content

FIX ExportJSON now imports aggregations from widget sheet #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabachello merged 1 commit into from
Apr 15, 2026
+12 −3
Merged

FIX ExportJSON now imports aggregations from widget sheet #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions Actions/ExportJSON.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,19 @@ protected function getDataSheetToRead(TaskInterface $task) : DataSheetInterface
// widget calling the action is a button and it normally does not know
// which columns to export.

// skip this step if we use the exportDataSheet as the reference (e.g. exporting from DataTables with a configurator)
$widget = $this->getWidgetToReadFor($task);
if ($widget && $this->getUseExportDataSheet($widget) === false) {
$dataSheet = $widget->prepareDataSheetToRead($dataSheet);
if ($widget !== null) {
$widgetSheet = $widget->prepareDataSheetToRead($dataSheet);
if($this->getUseExportDataSheet($widget) === false) {
$dataSheet = $widgetSheet;
} else {
// If we use the exportDataSheet as the reference (e.g. exporting from DataTables with a configurator)
// we need to transfer aggregations.
// TODO geb 2026-04-14: Is this the right place and do we need to import other properties as well?
foreach ($widgetSheet->getAggregations() as $aggregation) {
$dataSheet->getAggregations()->add($aggregation);
}
}
}

$dataSheet->removeRows();
Expand Down