[pull] master from beyond-all-reason:master - #64
Merged
Conversation
…3012) CamSpringTrackMapHeightMode=2 now bases the camera focus height on the air smooth mesh directly instead of nudging the zoom distance by per-frame smooth mesh deltas. The old implementation only applied while scrolling (zoom, minimap and Lua camera moves bypassed it), under-compensated by the view tilt factor, and accumulated drift since the offset lived in the zoom distance. - focus height = mix(ground, smooth mesh, smoothstep(min, max, dist)), fading to the raw terrain at close zoom so minimum zoom depth and panning speed stay identical to mode 1 near the ground - the mesh is sampled with a Catmull-Rom bicubic patch (SmoothHeightMesh::GetHeightSmooth), as the gradient creases of bilinear sampling show up as small camera jolts - ZoomIn/ZoomOut derive the camera distance against the same blended surface (march + bisection along the view ray), otherwise each zoom step lifts the camera by the mesh-to-ground gap and the view drifts - blend window configurable via CamSpringSmoothMeshBlendMin/MaxDist - mode 2 on a game with the smooth mesh disabled falls back to terrain tracking, checked in ConfigUpdate: controllers are constructed per game from CGame::LoadInterface, which runs after modInfo is loaded, so the mesh setting is known at that point - mode 0 (Disabled) keeps the old raycast re-base as FreezeCamHeight, minus its now-dead smooth delta branch; mode 1 (Terrain) is unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )