Refactor duplicated code into shared helpers.sh utilities

[devin-ai-integration]

Summary

Introduces scriptmodules/helpers.sh — a shared utility library that eliminates ~300 lines of duplicated code across 17 scripts by extracting common patterns into parameterized functions.

New helpers

# Doom WAD download (identical 12-line block repeated in 9 scripts)
_download_doom_port_wads()    # → ports/doom/
_download_doom_system_wads()  # → doom/

# Doom port registration (8-WAD if/chown/addPort block repeated per engine)
_add_doom_wad_ports "prefix" "Name" "$cmd"
_add_heretic_hexen_strife_ports "prefix" "Name" "$heretic_cmd" "$hexen_cmd" "$strife_cmd"

# Libretro build+configure (3-line make pattern in 9 cores)
_build_libretro_core "core_name"
_configure_libretro_port "port_name" "Display Name" "core.so"
_configure_libretro_system "system" "core.so" [default] [name] [exts]

Refactored scripts

Each script adds source "$(dirname "${BASH_SOURCE[0]}")/../helpers.sh" and replaces duplicated function bodies with single helper calls. Example diff for chocolate-doom.sh:

-function game_data_chocolate-doom() {
-    mkRomDir "ports"
-    mkRomDir "ports/doom"
-    if [[ ! -f "$romdir/ports/doom/doom1.wad" ]]; then ...12 lines... fi
-}
+function game_data_chocolate-doom() {
+    _download_doom_port_wads
+}

Doom ports (3): chocolate-doom, crispy-doom, eternity
Doom systems (5): chocolate-doom-system, crispy-doom-system, eternity-system, gzdoom-system, prboom-plus-system
Libretro cores (9): lr-2048, lr-craft, lr-blastem, lr-uzem, lr-oberon, lr-bk, lr-numero, lr-genesis-plus-gx-EX, lr-potator

All scripts pass bash -n syntax validation. Runtime behavior is identical — helpers use the same variables ($md_inst, $romdir, $md_id, etc.) that the RetroPie framework provides.

Link to Devin session: https://app.devin.ai/sessions/24af9600026a4bbd9e3585e46cef8f65
Requested by: @Exarkuniv

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring