Skip to content

feat(chart): parameterize image refs with registrySuffix (drop hardcoded "/") #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elronbandel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(chart): parameterize image refs with registrySuffix (drop hardcoded "/") #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions benchmarks/_chart/templates/job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
{{- end }}
containers:
- name: otelcol
image: {{ .Values.registry }}/core/otel:latest
image: {{ .Values.registry }}/core{{ .Values.registrySuffix }}otel:latest
imagePullPolicy: IfNotPresent
ports:
- { name: otlp-grpc, containerPort: 4317 }
Expand All @@ -34,7 +34,7 @@ spec:
- { name: output, mountPath: /output }

- name: gateway
image: {{ .Values.registry }}/models/{{ .Values.gatewayImage }}:{{ .Values.gatewayTag }}
image: {{ .Values.registry }}/models{{ .Values.registrySuffix }}{{ .Values.gatewayImage }}:{{ .Values.gatewayTag }}
imagePullPolicy: IfNotPresent
ports:
- { name: gateway, containerPort: 4000 }
Expand All @@ -60,7 +60,7 @@ spec:
{{- end }}

- name: runner
image: {{ .Values.registry }}/evals/{{ .Values.benchmark }}--{{ .Values.agent }}:{{ .Values.runnerTag }}
image: {{ .Values.registry }}/evals{{ .Values.registrySuffix }}{{ .Values.benchmark }}--{{ .Values.agent }}:{{ .Values.runnerTag }}
imagePullPolicy: IfNotPresent
command: ["/bin/bash", "-c"]
# $? / $rc are the container's shell — Helm leaves them untouched
Expand Down
6 changes: 6 additions & 0 deletions benchmarks/_chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@
agent: claude-code
task: "0"
registry: quay.io/eval-containers
# Separator between an image's category and name. "/" keeps the nested refs
# (registry/core/otel). A flattened internal registry (e.g. an OpenShift
# imagestream) sets "-" so each image collapses to registry/core-otel — set it
# once in a platform overlay (deploy/values-openshift.yaml). Mirrors the
# REGISTRY_SUFFIX build-arg on the Dockerfiles (PR #23).
registrySuffix: "/"
# The gateway is a fixed proxy image; `evalModel` is the upstream it proxies to
# (CLI --model sets evalModel + model). `model` is the runner's logging tag.
gatewayImage: gpt-5.4--bifrost
Expand Down