rules(models,gateways): remove the per-model image concept — one shared gateway (#294) - #295
Open
elronbandel wants to merge 1 commit into
Open
rules(models,gateways): remove the per-model image concept — one shared gateway (#294)#295elronbandel wants to merge 1 commit into
elronbandel wants to merge 1 commit into
Conversation
…ed gateway, models are runtime-only (#294) Doctrine half of #294 (the #187 pattern). The model axis keeps exactly one image kind: the shared generic gateway, with the model always selected at runtime via EVAL_MODEL. - models rule 1: images that bake an upstream model are forbidden; replay (rule 17) is the sole sanctioned exception. - models rule 12 retargeted to the gateway build-time version pin (gateway.<flavor>_version); rule 13 (EVAL_LITELLM_VERSION runtime override — unimplemented since #50) deprecated in place; rule 15 labels retargeted to gateway.kind; rule 16's enforcement pointer to the deleted core/litellm entrypoint dropped. - gateways rules 16-17: one combo per flavor (models/<flavor> FROM gateways/<flavor>), per-model combos (models/<model>--<gateway>) forbidden. - RULES.md principle 9 + src rules 10/12: EVAL_LITELLM_VERSION / --litellm-version dropped from the internal-version axis. - add-benchmark template + audit-rules-drift example updated to the single-path story. Checked against: meta/rules 9-10 (changelogs, deprecate-in-place), contributing 1-3. Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
elronbandel
force-pushed
the
elron/no-per-model-images-rules
branch
from
August 9, 2026 14:35
5790d93 to
0050146
Compare
elronbandel
added a commit
that referenced
this pull request
Aug 9, 2026
…models picked at runtime (#294) Implementation half of #294 (doctrine: #295). The model axis now has exactly one image kind: the shared generic gateway. EVAL_MODEL=<provider>/<model> is the only way to pick a model; EVAL_GATEWAY_IMAGE picks only the proxy flavor (bifrost default; litellm/portkey). models/replay stays as the sole pinned exception (models rule 17). Removed: - containers/models/{gpt-5,gpt-5.4,gpt-4.1-mini,claude-opus-4,claude-sonnet-4} (the five pinned per-model images) and containers/core/litellm, their only base — orphaned once they are gone (gateways/litellm is independent). - The litellmVersion chart knob + EVAL_LITELLM_VERSION env plumbing (unimplemented since #50) and the litellm-version rego gates, which matched exactly the five deleted Dockerfiles. Retargeted guards: - tests/static/model-paths.sweep.sh: asserts the single path — default flavor + flavor swap, with the handle always reaching the gateway at runtime. - tests/static/check.rs::model_axis_generic_default_no_silent_model: every models/<name> image must be FROM a gateways/<flavor> image (replay excepted), so a per-model image cannot sneak back in. deploy/oc scripts un-conflated: --model is now the <provider>/<model> handle (what the chart's `model` value actually is) and --gateway the flavor; the dead evalModel plumbing and the --bifrost-suffix-stripping handle derivation are gone; result paths key on the clean model label. Docs, PR/issue templates, and .env.example collapse to the single-path story; stale core/litellm pointers now name gateways/litellm. Checked against: models/RULES.md 1, 12-17; gateways/RULES.md 16-17; RULES.md 8-9, 15; src/RULES.md 10, 12; verification/RULES.md (static gates green: cargo test -p eval-containers + --test check + dockerfile_inspection, conftest verify 80/80, helm sweep 102/102, model-paths sweep). BREAKING CHANGE: the models/{gpt-5,gpt-5.4,gpt-4.1-mini,claude-opus-4, claude-sonnet-4} images are no longer published; set EVAL_MODEL=<provider>/<model> on the shared gateway instead. Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doctrine half of #294, following the #187 pattern (rules first, implementation second — contributing rule 2). The implementation PR is #296.
What changes
The model axis keeps exactly one framework image kind: the shared generic gateway.
EVAL_MODEL=<provider>/<model>is the only way to pick a model; the image only picks the proxy flavor.models/replaystays as the sole in-tree pinned exception.replay(rule 17) is the single in-tree exception.FROMa publishedgateways/<flavor>+ config template only, selected via the standard image seam (EVAL_GATEWAY_IMAGE/gatewayImageRef). Explicitly non-default; never in the framework's tree or registry. This is the backward-compatibility escape hatch for teams that relied on a pinned image's custom config — they can rebuild the identical artifact in their own registry.core/litellmpin to the gateway build-time pin (gateway.<flavor>_version, gateways rule 14).EVAL_LITELLM_VERSIONruntime override has had no implementer since Delete dead eval-entrypoint.sh #50 and its only intended consumers (the pinned per-model images) are being removed.eval.type+gateway.kind(replay keepseval.model.*).containers/core/litellm/eval-litellm-entrypoint.shdropped (the base image goes with the pinned images); the cap requirement itself is unchanged.models/<flavor>FROM gateways/<flavor>, template-only); per-model combos are no longer published by the framework, while downstream template-only derivations stay permitted (models rule 1a).EVAL_LITELLM_VERSION/--litellm-versiondropped from the internal-version axis and CLI parity list.All four changed
RULES.mdfiles carry dated changelog entries.Rules checked against
.agents/meta/rules/RULES.md9 (changelog required), 10 (deprecate in place, no silent renumbering), 11–14 (form)..agents/contributing/RULES.md1–3 (resolves Remove per-model gateway images — one shared model gateway, models are runtime-only #294; rules-only; declared here).Resolves the doctrine half of #294.