Skip to content

fix(gateways): strip trailing /v1 from OPENAI_API_BASE in bifrost/start #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cdoron wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(gateways): strip trailing /v1 from OPENAI_API_BASE in bifrost/start #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion containers/gateways/bifrost/start
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,16 @@ if [ -f "$TEMPLATE" ]; then
: "${OTEL_EXPORTER_OTLP_ENDPOINT:=http://otelcol:4318}"
OTEL_COLLECTOR_URL="${OTEL_EXPORTER_OTLP_ENDPOINT%/}/v1/traces"

# bifrost's openai/anthropic provider clients append their own /v1/... path,
# so network_config.base_url must be the bare root — but OPENAI_API_BASE
# follows the OpenAI-SDK convention of already including /v1 (see
# docs/guides/deploy-on-kubernetes.md). Strip it here so the template's
# ${OPENAI_API_BASE} substitution lands on the root the client expects
# (mirrors litellm/start's identical normalization).
ROOT_API_BASE=${OPENAI_API_BASE:-}; ROOT_API_BASE=${ROOT_API_BASE%/}; ROOT_API_BASE=${ROOT_API_BASE%/v1}

sed -e "s|\${GOVERNANCE}|${GOVERNANCE}|g" \
-e "s|\${OPENAI_API_BASE}|${OPENAI_API_BASE-}|g" \
-e "s|\${OPENAI_API_BASE}|${ROOT_API_BASE}|g" \
-e "s|\${OTEL_COLLECTOR_URL}|${OTEL_COLLECTOR_URL}|g" \
< "$TEMPLATE" > "$CONFIG"
fi
Expand Down