Skip to content

Make the io_test more reliable (backport #9387) - #9393

Merged
kevinbackhouse merged 6 commits into
mainfrom
mergify/bp/main/pr-9387
Jul 23, 2026
Merged

Make the io_test more reliable (backport #9387)#9393
kevinbackhouse merged 6 commits into
mainfrom
mergify/bp/main/pr-9387

Conversation

@mergify

@mergify mergify Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Fixes: #9389

@v-davit-ioramashvili investigated what's happening on the macos runners and figured out that it takes approximately 35s for the port to start listening: actions/runner-images#14409 (comment). So the solution to the problem is fairly simple: wait for up to 90s before giving up and failing the test.

I've done a second thing in this PR, which is no longer necessary but should still help to make this test more reliable: rather than hardcoding a specific port number, the test searches for a free port. I wrote the code to search for a port before I found out the real reason why the test is failing, but I think we might as well keep it.


This is an automatic backport of pull request #9387 done by Mergify.

@mergify mergify Bot added the conflicts label Jul 22, 2026
@mergify

mergify Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of ca5f306 has failed:

On branch mergify/bp/main/pr-9387
Your branch is up to date with 'origin/main'.

You are currently cherry-picking commit ca5f3067.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   README.md
	modified:   tests/bash_tests/utils.py
	modified:   tests/suite.conf
	modified:   tests/system_tests.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tests/bash_tests/testcases.py

Cherry-pick of a79648f has failed:

On branch mergify/bp/main/pr-9387
Your branch is ahead of 'origin/main' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit a79648f9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tests/bash_tests/utils.py

no changes added to commit (use "git add" and/or "git commit -a")

Cherry-pick of bfdc2c8 has failed:

On branch mergify/bp/main/pr-9387
Your branch is ahead of 'origin/main' by 3 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit bfdc2c8f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tests/bash_tests/utils.py

no changes added to commit (use "git add" and/or "git commit -a")

Cherry-pick of 5484131 has failed:

On branch mergify/bp/main/pr-9387
Your branch is ahead of 'origin/main' by 4 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 54841313.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tests/bash_tests/utils.py

no changes added to commit (use "git add" and/or "git commit -a")

Cherry-pick of bb292b0 has failed:

On branch mergify/bp/main/pr-9387
Your branch is ahead of 'origin/main' by 5 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit bb292b02.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   README.md
	modified:   tests/bash_tests/utils.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tests/bash_tests/testcases.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@kevinbackhouse
kevinbackhouse force-pushed the mergify/bp/main/pr-9387 branch from 21c4176 to 96ef48e Compare July 22, 2026 20:15
@kevinbackhouse
kevinbackhouse requested review from kmilos and neheb July 23, 2026 13:27
@mergify

mergify Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@kevinbackhouse
kevinbackhouse merged commit 111bfa4 into main Jul 23, 2026
110 of 111 checks passed
@kevinbackhouse
kevinbackhouse deleted the mergify/bp/main/pr-9387 branch July 23, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests keep failing on macos-latest runners

2 participants