Make the io_test more reliable (backport #9387) - #9393
Merged
Conversation
Contributor
Author
|
Cherry-pick of ca5f306 has failed: Cherry-pick of a79648f has failed: Cherry-pick of bfdc2c8 has failed: Cherry-pick of 5484131 has failed: Cherry-pick of bb292b0 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
kevinbackhouse
force-pushed
the
mergify/bp/main/pr-9387
branch
from
July 22, 2026 17:30
47fb425 to
21c4176
Compare
kevinbackhouse
force-pushed
the
mergify/bp/main/pr-9387
branch
from
July 22, 2026 20:15
21c4176 to
96ef48e
Compare
kmilos
approved these changes
Jul 23, 2026
Contributor
Author
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9389
@v-davit-ioramashvili investigated what's happening on the macos runners and figured out that it takes approximately 35s for the port to start listening: actions/runner-images#14409 (comment). So the solution to the problem is fairly simple: wait for up to 90s before giving up and failing the test.
I've done a second thing in this PR, which is no longer necessary but should still help to make this test more reliable: rather than hardcoding a specific port number, the test searches for a free port. I wrote the code to search for a port before I found out the real reason why the test is failing, but I think we might as well keep it.
This is an automatic backport of pull request #9387 done by Mergify.