Check for duplicates in RiffVideo::readInfoListChunk (backport #9369) - #9394
Open
mergify[bot] wants to merge 2 commits into
Open
Check for duplicates in RiffVideo::readInfoListChunk (backport #9369)#9394mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
Contributor
Author
|
Cherry-pick of 2fee7b3 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had some security reports about
RiffVideo::readInfoListChunk()because it's a bit slow when you give it a long list to process. The complexity of this code is linear but the constant factor cost of inserting an element intoxmpData_is high. I got a 4x speedup by copying the elements into astd::mapfirst (to eliminate duplicate keys). But duplicate keys probably only happen in malformed input files, so I've also added anenforceto disallow duplicates.I don't think this is a security issue because it's just slow performance. It's not a quadratic algorithm, just constant factor slowness.
This is an automatic backport of pull request #9369 done by Mergify.