ci: add exodus-build workflow for release artifact production#19
Closed
raxodus wants to merge 1 commit into
Closed
ci: add exodus-build workflow for release artifact production#19raxodus wants to merge 1 commit into
raxodus wants to merge 1 commit into
Conversation
Reuses V1's build-* workflow_call workflows but skips the github.repository == 'facebook/hermes' gating and the Sonatype publishing path. Manual workflow_dispatch trigger; outputs are attached to the run for `gh run download` retrieval. facebook/hermes/build will continue to fail on this branch because 0013 (EnableEval=false) breaks the eval/Function unit tests by design. This workflow does not run the test target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.github/workflows/exodus-build.yml, a manually-triggered workflow that orchestrates V1's existingbuild-*reusable workflows to produce@exodus/hermes-enginerelease artifacts (iOS tarball + Android AARs) without depending on facebook/hermes's Sonatype credentials.V1's upstream
rn-build-hermes.ymlis gated togithub.repository == 'facebook/hermes'and publishes to Maven Central via secrets we don't have. This workflow reuses the samebuild-hermesc-apple→build-apple-slices-hermes→build-hermes-macoschain and thebuild-androidworkflow directly, then leaves the artifacts on the run for retrieval viagh run download.Why facebook/hermes/build always fails on exodus-v1
0013 (
set enableEval to false) breaks the eval/Function unit tests by design. This workflow does NOT run the test target, so artifact production succeeds.Test plan
gh workflow run exodus-build.yml --repo ExodusForks/hermes --ref exodus-v1 -f release-type=dry-runhermes-darwin-bin-Release,hermes-darwin-bin-Debug,maven-local,hermes-dSYM-{Debug,Release}gh run download <run-id>and verify the iOS tarball / AAR layouts match whatsrc/patches-prod/hermes-engine.diffexpects