Skip to content

Fix off-by-one bounds check in utf8.js deLoose function #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Draft

Fix off-by-one bounds check in utf8.js deLoose function #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e77c64d
Initial plan
Copilot Jan 28, 2026
7fc67dd
Fix bounds check in utf8.js deLoose function
Copilot Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions utf8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ function deLoose(str, loose, res) {

// Recheck if the string was encoded correctly
let start = 0
const last = res.length - 2
// Search for EFBFBD
while (start < last) {
const last = res.length - 3
// Search for EFBFBD (3-byte sequence)
while (start <= last) {
const pos = res.indexOf(0xef, start)
if (pos === -1) break
if (pos === -1 || pos > last) break
start = pos + 1
if (res[pos + 1] === 0xbf && res[pos + 2] === 0xbd) {
// Found a replacement char in output, need to recheck if we encoded the input correctly
Expand Down