Skip to content

fix: children key in attrs#34

Merged
gutenye merged 3 commits intomasterfrom
guten/children
Mar 4, 2025
Merged

fix: children key in attrs#34
gutenye merged 3 commits intomasterfrom
guten/children

Conversation

@gutenye
Copy link
Copy Markdown
Contributor

@gutenye gutenye commented Mar 4, 2025

Fix https://github.com/ExodusMovement/exodus-mobile/issues/24584

Without the fix, below code won't work

styled(Text).attrs({ children: 'Foo' })

Not sure what caused this issue.

@gutenye gutenye requested review from a team, headfire94 and sparten11740 March 4, 2025 06:16
Copy link
Copy Markdown
Contributor

@headfire94 headfire94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@headfire94 headfire94 requested a review from alexandrius March 4, 2025 06:29
@gutenye gutenye merged commit cc514ed into master Mar 4, 2025
4 checks passed
@gutenye
Copy link
Copy Markdown
Contributor Author

gutenye commented Mar 4, 2025

@headfire94 Could you publish it? I don't have permisson.

@headfire94
Copy link
Copy Markdown
Contributor

@alexandrius has

@alexandrius
Copy link
Copy Markdown
Contributor

Can we have special value or label prop for Text?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants