chore(63871): update @onfido/react-native and onfido-sdk-ui#69591
chore(63871): update @onfido/react-native and onfido-sdk-ui#69591roryabraham merged 26 commits intoExpensify:mainfrom
Conversation
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
|
There are tests failing but these come from main |
1cd7c63 to
c032ddf
Compare
|
Now everything is green. Any chance you can take a look @jayeshmangwani? |
|
@Kureev Please include the |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid.mp4Android: mWeb Chromemweb-chrome.mp4iOS: HybridAppiOS.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
|
@Kureev Onfido is throwing an error on Android, and the console shows this message: Android-bug.mp4 |
|
Gotcha, looking into this |
853f4ac to
10f0d31
Compare
|
@Kureev Please ping me once the Android issue is fixed and the PR is ready for review again. |
10f0d31 to
c092aec
Compare
I just managed to connect a bank account through the wallet. Not sure if it was the same flow as you tried, @jayeshmangwani, but if it's not, could you please tell me how to follow your steps more precisely?
|
|
@Kureev Yes sure adding the details below Steps Followed:
I’ve added a video below showing how I added a bank account to reach the Verify identity page. You can use the same values from the video in the required fields if needed. onfido.mov |
c092aec to
8f0e9cc
Compare
|
@jayeshmangwani fixed the issue with the NFC, but it doesn't go further than the selfie as I don't have a real device, so can't really test it further |
|
@Kureev Are we sure it’s safe to delete |
|
I think the committed |
| sdkToken, | ||
| theme: OnfidoTheme.AUTOMATIC, | ||
| // eslint-disable-next-line | ||
| nfcOption: OnfidoNFCOptions.DISABLED, |
There was a problem hiding this comment.
Curious — why are we disabling ESLint here? I don’t see any lint warnings locally for nfcOption: OnfidoNFCOptions.DISABLED.
There was a problem hiding this comment.
I do have two errors from eslint there
Latest changes seem to be working, I can test the selfie, video, and audio recording parts on Onfido now. |
I can compose a smaller PR that will include only Onfido-related changes if you'd like. |
I was under the impression that we’d need to add the Mobile-Expensify changes in the Mobile-Expensify repo rather than this one. That said, the PR looks good overall and tests well. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@Kureev we also need an OD PR because hybrid iOS builds are failing now due to a lack of changes in the Podfile.lock |
|
We updated lock here: https://github.com/Expensify/Mobile-Expensify/pull/13708 |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.16-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀
|



Explanation of Change
Update @onfido/react-native and onfido-sdk-ui are built with 16Kb memory pages (
align=0x4000), which is required for Android 15+ compatibility.armeabi-v7alibs remain at 4 KB alignment, which is expected since Android 15+ devices no longer run 32-bit code.MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13661
Fixed Issues
$ #63871
PROPOSAL: #63871
Tests
llvm-readelf -lon allarm64-v8a.so files and confirmedp_align=0x4000(16 KB) for each.zipalign -c -P 16.scripts/check-16kb-android.shwith the path to the APK to check all alignments in the bundle.Offline tests
QA Steps
Same as tests:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop