Skip to content

perf: Migrate to Flashlist in MoneyRequestReportTransactionList #91422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TMisiukiewicz wants to merge 57 commits into
base: main
Choose a base branch
from
Open

perf: Migrate to Flashlist in MoneyRequestReportTransactionList #91422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
4b12b1a
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz May 22, 2026
4551621
perf: migrate transaction list from .map() to FlashList for virtualiz…
TMisiukiewicz May 21, 2026
f68b1ee
perf: unify transactions + actions into one virtualised list
TMisiukiewicz May 22, 2026
d64ff24
fix: restore lastTransactionID and isDesktopTableLayout
TMisiukiewicz May 22, 2026
f4fbe38
fix: CI spellcheck and remove memoization wrappers
TMisiukiewicz May 25, 2026
1ee223b
fix: rephrase virtualized comment to satisfy cspell
TMisiukiewicz May 25, 2026
52ceec0
use Flashlist
TMisiukiewicz May 25, 2026
2779f70
refactor: extract unified list render-prop body into sub-component
TMisiukiewicz May 25, 2026
71af131
fix: hoist long-press modal out of virtualised footer cell
TMisiukiewicz May 25, 2026
81bb0f0
Merge branch 'main' into perf/virtualised-report-list
TMisiukiewicz May 25, 2026
1220e39
refactor: extract long-press modal and horizontal scroll wrapper comp…
TMisiukiewicz May 25, 2026
6b5c9be
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz May 26, 2026
143946e
remove dead keyExtractor from transaction list controller
TMisiukiewicz May 26, 2026
03ce297
fix unread marker index offset when transactions are present
TMisiukiewicz May 26, 2026
4af0be0
avoid scanning transactions when resolving linked action index
TMisiukiewicz May 26, 2026
2a930b8
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz May 26, 2026
27b98dd
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz May 27, 2026
e58e95c
Pin scroll to bottom while deferred report items hydrate
TMisiukiewicz May 27, 2026
c89d0da
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz May 27, 2026
aea7de0
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz May 27, 2026
27f405d
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz May 28, 2026
08653dd
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz May 28, 2026
25e7c49
allow to skip deferring RBR message to prevent dynamic changes to ite…
TMisiukiewicz May 28, 2026
9623fb0
add drawDistance
TMisiukiewicz May 28, 2026
d297183
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz May 29, 2026
8e92d9b
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz May 29, 2026
d437268
Merge branch 'main' into perf/virtualised-report-list
TMisiukiewicz Jun 1, 2026
7c40dfc
Extract MoneyRequestReportUnifiedList and remove render-prop inversion
TMisiukiewicz Jun 1, 2026
c009779
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz Jun 1, 2026
06ff7ac
Merge branch 'main' into perf/virtualised-report-list
TMisiukiewicz Jun 1, 2026
c834467
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz Jun 2, 2026
1884a8d
Defer mark-as-read until scroll reaches bottom in Latest messages
TMisiukiewicz Jun 2, 2026
032cb74
Precompute report-action errors once for per-transaction RBR check
TMisiukiewicz Jun 2, 2026
d681da1
Feed stable report projection to transaction list to avoid read-state…
TMisiukiewicz Jun 2, 2026
033ef71
Pass transaction thread ID so report-view rows skip RBR inner when empty
TMisiukiewicz Jun 2, 2026
52e87f1
Jump to latest messages via scrollToIndex to avoid blank landing on l…
TMisiukiewicz Jun 2, 2026
4239613
remove timeout
TMisiukiewicz Jun 2, 2026
a92c4da
Revert "remove timeout"
TMisiukiewicz Jun 2, 2026
1e187a7
Merge branch 'main' of https://github.com/Expensify/App into perf/vir…
TMisiukiewicz Jun 2, 2026
03b0b31
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz Jun 3, 2026
5546ddf
remove dead code (knip)
TMisiukiewicz Jun 3, 2026
961619b
fix spellcheck
TMisiukiewicz Jun 3, 2026
9845546
fix lint
TMisiukiewicz Jun 3, 2026
6584330
fix knip
TMisiukiewicz Jun 3, 2026
b6382a1
fix knip
TMisiukiewicz Jun 3, 2026
11c274d
Merge branch 'main' into perf/virtualised-report-list
adhorodyski Jun 5, 2026
7f65626
Merge remote-tracking branch 'exfy/main' into perf/virtualised-report…
adhorodyski Jun 9, 2026
d371d26
Merge branch 'Expensify:main' into perf/virtualised-report-list
adhorodyski Jun 10, 2026
c2f98c0
Forward report list ref via @components/FlashList instead of unsafe c…
adhorodyski Jun 10, 2026
98b1b27
Drop now-unused UnifiedListItem export
adhorodyski Jun 10, 2026
4fdc5ff
Merge remote-tracking branch 'exfy/main' into perf/virtualised-report…
adhorodyski Jun 15, 2026
22ca09a
Remove unused eslint-disable directive for jsx-props-no-spreading
adhorodyski Jun 15, 2026
36d0f52
Merge remote-tracking branch 'exfy/main' into perf/virtualised-report…
adhorodyski Jun 15, 2026
9d42673
Merge ck/main into perf/virtualised-report-list
TMisiukiewicz Jun 16, 2026
6a58ae0
Merge branch 'Expensify:main' into perf/virtualised-report-list
adhorodyski Jun 19, 2026
b6f91e1
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz Jun 23, 2026
80de6da
Merge remote-tracking branch 'origin/main' into perf/virtualised-repo…
TMisiukiewicz Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CONST/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1839,6 +1839,7 @@ const CONST = {
THREAD_DISABLED: ['CREATED'],
LATEST_MESSAGES_PILL_SCROLL_OFFSET_THRESHOLD: 2000,
ACTION_VISIBLE_THRESHOLD: 250,
AUTOSCROLL_TO_TOP_THRESHOLD: 250,
LINKED_MESSAGE_OFFSET: 40,
MAX_GROUPING_TIME: 300000,
},
Expand Down
90 changes: 0 additions & 90 deletions src/components/FlatList/FlatListWithScrollKey/BaseFlatListWithScrollKey.tsx
View file
Open in desktop

This file was deleted.

62 changes: 0 additions & 62 deletions src/components/FlatList/FlatListWithScrollKey/index.ios.tsx
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions src/components/FlatList/FlatListWithScrollKey/index.tsx
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions src/components/FlatList/FlatListWithScrollKey/types.ts
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/components/FlatList/getInitialPaginationSize/index.native.ts
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/components/FlatList/getInitialPaginationSize/index.ts
View file
Open in desktop

This file was deleted.

183 changes: 0 additions & 183 deletions src/components/FlatList/hooks/useFlatListScrollKey.ts
View file
Open in desktop

This file was deleted.

Loading
Loading