Fix: Total spend footer does not always appear when all expenses are selected

[lorretheboy]

Explanation of Change

Fixed Issues

$ #96116
PROPOSAL:

Tests

Precondition:

• Account has many expenses (450+).

1. Go to staging.new.expensify.com
2. Go to Spend > Expenses.
3. Click Select all checkbox > Select all on this page.
4. Deselect Select all checkbox.
5. Click Select all checkbox > Select all.
6. Deselect Select all checkbox.
7. Repeat Step 5 and 6 multiple times (select all right after deselecting)
8. Verify that Total spend footer will always appear when all expenses are selected.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

• Account has many expenses (450+).

1. Go to staging.new.expensify.com
2. Go to Spend > Expenses.
3. Click Select all checkbox > Select all on this page.
4. Deselect Select all checkbox.
5. Click Select all checkbox > Select all.
6. Deselect Select all checkbox.
7. Repeat Step 5 and 6 multiple times (select all right after deselecting)
8. Verify that Total spend footer will always appear when all expenses are selected.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2026-08-10.at.15.45.50.mov

Android: mWeb Chrome

Screen.Recording.2026-08-10.at.15.48.54.mov

iOS: Native

Screen.Recording.2026-08-10.at.15.41.15.mov

iOS: mWeb Safari

Screen.Recording.2026-08-10.at.15.37.58.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-14.at.14.35.38.mov

[lorretheboy]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 42dc3ab6fb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[melvin-bot]

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

@lorretheboy Could you close this PR? Or marking it as a draft

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9f2f4cc9e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[DylanDylann]

@lorretheboy Could you explain the RCA again, and why it only happens on accounts that have many expenses?

[lorretheboy]

@DylanDylann On an ad-hoc Expenses search, shouldCalculateTotals is true only while all-matching is selected (useSearchShouldCalculateTotals). So:

1. Deselect → flag flips to false → the search effect re-runs an offset === 0 search without totals → shouldClearTotals (Search.ts) optimistically MERGEs {count: null, total: null, currency: null}. Onyx MERGE null = delete, so the totals we already have are wiped.

2. Re-select all → we fire a totals request to get them back, but dedupeKey = hash_offset (Search.ts) matches the no-totals request still in flight, so it's silently dropped. The retry ref is cleared before the call (index.tsx), and shouldCalculateTotals is already true, so nothing re-fires. count stays gone → footer never returns for that hash.

Why only big accounts: it's purely a race against the request round-trip. shouldCalculateTotals: true makes the BE aggregate over all matching expenses, and the bigger payload lengthens the Onyx write queue that waitForWrites blocks on. Smallaccount = a few tens of ms, you can't click fast enough (why we couldn't repro). 450+ expenses = seconds, easy to hit.

[DylanDylann]

@lorretheboy In the testing steps, please emphasize that we need to select all right after deselecting in order to test this

[lorretheboy]

@DylanDylann I updated the test steps

[DylanDylann]

@lorretheboy In your fix, you made two changes:

1. Updating dedupeKey, so that when users select all again, a new search API call is triggered and returns the total and count values again.
2. Could you clarify the purpose of updating useSearchShouldCalculateTotals?

[DylanDylann]

From my testing, it works well with just the dedupeKey fix. So I'm wondering whether the second change is actually needed here

[DylanDylann]

@lorretheboy Kindly bump

[lorretheboy]

I will recheck today

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[lorretheboy]

@DylanDylann Please review again. Thanks

[DylanDylann]

Why do you remove !!currentSearchResults?.search?.isLoading

[DylanDylann]

One more question, What will display when hasSearchErrors is true?

[lorretheboy]

They are from 2 different API calls, it belongs to a single request which we should not consider here to avoid another UI glitch @DylanDylann

[DylanDylann]

@lorretheboy Could you elaborate in more detail? I'm still a bit confused

[lorretheboy]

So here is the issue @DylanDylann

search.isLoading is set/cleared by any Search API call on that snapshot hash, but search.count only comes back from a call made with shouldCalculateTotals: true. Those are two different requests.

Eg: a refresh/paginated search with shouldCalculateTotals: false nulls count at offset === 0 and flips isLoading back to false, and only after that does the retry effect in Search/index.tsx fire the totals request. So with the old condition there's a window where isLoading === false but count is still missing → the skeleton disappears, the button briefly shows the local selection count, then flips back to loading and finally to the real total.

[DylanDylann]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 43a2c44fcd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[lorretheboy]

@DylanDylann You can do another review now. Thanks

[DylanDylann]

@lorretheboy Bump on this #96120 (comment)

[lorretheboy]

@DylanDylann I explained the situation in more detailed way for you

[DylanDylann]

@lorretheboy Please upload videos for all platforms. It looks like this isn't the first time you missed it, even though you checked this item off in your checklist

I included screenshots or videos for tests on all platforms

[lorretheboy]

@DylanDylann It was my bad. I will upload them shortly. For this specific PR, it used to be a deploy blocker so I raised a fix PR with only macos chrome recording in order to be a quick fix PR to resolve to DB.

However, I will note this for future. Thanks for remind me

[DylanDylann]

, it used to be a deploy blocker so I raised a fix PR with only macos chrome recording in order to be a quick fix PR to resolve to DB.

Don't agree. The PR was created weeks ago, and the video is still missing

[lorretheboy]

Don't agree. The PR was created weeks ago, and the video is still missing

Sorry for my wordings that make you misunderstanding. I mean it was my bad, I raised the PR with MacOs chrome recording to fix a DP after 23 mins since assignment to resolve the bug quickly. Then we decide to close this PR for a week then reopen which made me forget to update all other platforms.

I noted this case down for future. Thank you for reminding @DylanDylann

[lorretheboy]

@DylanDylann I uploaded recordings. Thanks

[luacmartins]

Why are we getting rid of the allMatchingItemsSelected copy?

[DylanDylann]

@luacmartins We no longer use this. If users select all expenses, we'll display a loading indicator until the API returns the count

[luacmartins]

@lorretheboy conflicts

[lorretheboy]

@luacmartins Conflicts resolved. Please check. Thanks