fix(a11y): add iOS VoiceOver support to picker and Done button#22
Open
TaduJR wants to merge 1 commit intoExpensify:masterfrom
Open
fix(a11y): add iOS VoiceOver support to picker and Done button#22TaduJR wants to merge 1 commit intoExpensify:masterfrom
TaduJR wants to merge 1 commit intoExpensify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds built-in accessibility to
renderIOS()and the Done button, matching the pattern already established inrenderAndroidHeadless()(PR #19).iOS picker wrapper (
ios_touchable_wrapper)accessible={true}accessibilityRole="combobox"accessibilityLabelextracted frompickerProps.accessibilityLabelaccessibilityState={{ disabled, expanded: showPicker }}Done button (
done_button)accessibilityRole="button"accessibilityLabel={doneText}Library props are placed after
{...touchableWrapperProps}/{...touchableDoneProps}so library values take precedence, ensuring consistent screen reader behavior.cc @eVoloshchak @inimaga