Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Replace the old SSH-based Lean4 engine with a clean HTTP client/server architecture using FastAPI + docker exec. Strip dead SSH artifacts from Dockerfile, narrow broad except clauses to specific types, unify port finding via atomic bind(0), and fix server-stop message style. (fix) address CodeQL and code-quality findings Bind ephemeral port-finding sockets to 127.0.0.1 instead of all interfaces, sanitize Docker error details from /health response, and annotate intentional NotFound except-pass blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker exec)sleep infinitydocker-compose.yml(SSH-only config)except Exceptionclauses to specific types (docker.errors.DockerException,docker.errors.APIError,OSError,subprocess.SubprocessError)socket.bind(("", 0))replacing O(n) port scan with TOCTOU raceUserMessage("Server stopped!")warning → success style for all symserverKeyboardInterrupthandlersArgumenttype instead ofAnyon engineforward()/prepare()signaturesTest plan
ruff checkpasses on all changed files