Skip to content

Fix assistant KB MCP tool names#531

Merged
jorisjonkers-dev-agents[bot] merged 1 commit into
mainfrom
fix/assistant-kb-mcp-tool-names
Jun 4, 2026
Merged

Fix assistant KB MCP tool names#531
jorisjonkers-dev-agents[bot] merged 1 commit into
mainfrom
fix/assistant-kb-mcp-tool-names

Conversation

@jorisjonkers-dev-agents

Copy link
Copy Markdown
Contributor

Summary

  • Switch assistant-api's knowledge MCP adapter to the canonical dot-form knowledge.recall and knowledge.capture_lesson tool names.
  • Parse MCP JSON-RPC responses from raw strings so the thin adapter does not depend on RestClient's JsonNode converter behavior.
  • Add focused request/response tests for recall, capture, and disabled RAG behavior.

Verification

  • ./gradlew :services:assistant-api:test
  • ./gradlew :services:assistant-api:ktlintCheck :services:assistant-api:detekt

Not run

  • ./gradlew :services:assistant-api:integrationTest could not complete because Testcontainers could not find a Docker environment (/var/run/docker.sock missing).

@jorisjonkers-dev-agents jorisjonkers-dev-agents Bot added the bug Something isn't working label Jun 4, 2026
@jorisjonkers-dev-agents jorisjonkers-dev-agents Bot merged commit 3df50f6 into main Jun 4, 2026
41 checks passed
@jorisjonkers-dev-agents jorisjonkers-dev-agents Bot deleted the fix/assistant-kb-mcp-tool-names branch June 4, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant