fix(agents-api): wire CREDENTIAL_INGEST_BEARER so credential ingest stops 401-ing#737
Merged
Merged
Conversation
…uthenticates Posting a captured credential to /api/v1/internal/credentials returned 401 Unauthorized. The endpoint is guarded by InternalBearerAuthFilter, which compares the request's bearer against CREDENTIAL_INGEST_BEARER. The agents-api Deployment never set that variable, so the filter had no expected token and rejected every request as "Internal endpoint not configured". The agents-login worker already presents the shared agents-login-internal token as its bearer. Both agents-api Deployments now source CREDENTIAL_INGEST_BEARER from the same secret key, so the presented and expected tokens match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
After the worker started reaching agents-api (the lease fix in #736), submitting an authorization code failed with:
Root cause
/api/v1/internal/credentialsis guarded byInternalBearerAuthFilter(props.credentialIngestBearer). That property is sourced fromCREDENTIAL_INGEST_BEARER, which the agents-api Deployment never set. With no configured bearer the filter takes itsexpected == nullbranch and rejects every request as "Internal endpoint not configured" (surfaced to the browser as a bare 401).The agents-login worker already presents the shared
agents-login-internaltoken as itsAuthorization: Bearer. The Deployment only wired that secret intoINTERNAL_TOKEN(the token agents-api uses to call the worker), not into the ingest bearer the filter checks.Fix
Both agents-api Deployments (
deployment.yamlanddeployment-enschede-ws.yaml) now sourceCREDENTIAL_INGEST_BEARERfromagents-login-internal/token— the same secret key the worker presents — so expected and presented tokens match.Validation
kubectl kustomize platform/cluster/flux/apps/stateless/agents-apirenders both deployments withCREDENTIAL_INGEST_BEARER; platform tests pass (56/56).