[fix]: Update org unit parameter changes in v42#387
Open
deeonwuli wants to merge 5 commits intodevelopmentfrom
Open
[fix]: Update org unit parameter changes in v42#387deeonwuli wants to merge 5 commits intodevelopmentfrom
deeonwuli wants to merge 5 commits intodevelopmentfrom
Conversation
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
gqcorneby
reviewed
Mar 5, 2026
src/data/Dhis2RelationshipTypes.ts
Outdated
| return { ouMode, orgUnit: buildOrgUnitsParameter(orgUnits) }; | ||
| const orgUnitsParam = buildOrgUnitsParameter(majorVersion, orgUnits); | ||
| if (majorVersion >= 42) return { orgUnitMode: ouMode, orgUnits: orgUnitsParam }; | ||
| else if (majorVersion === 41) return { ouMode: ouMode, orgUnit: orgUnitsParam }; |
There was a problem hiding this comment.
Looks like the return for this is the same as the one in the else branch, we can remove this else if branch, right?
5 tasks
Author
|
I have added @MatiasArriola to review these changes as he suggested some improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
buildOrgUnitModeto check the api version and return the ou parameters correctly🔥 Notes for the reviewer
📹 Screenshots/Screen capture
Screen.Recording.2026-03-04.at.17.08.34.mov
📑 Others
#869cb326m