Feature/better fail detection on previous run#67
Open
idelcano wants to merge 2 commits intodevelopmentfrom
Open
Feature/better fail detection on previous run#67idelcano wants to merge 2 commits intodevelopmentfrom
idelcano wants to merge 2 commits intodevelopmentfrom
Conversation
…ore failed, and we need throw a raise exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ore failed, and we need throw a raise exception
This PR is an attempt to improve error detection during the setup process.
If an execution fails midway, the materialized views are not dropped. If the process is restarted and d2-cloner is in strict mode, it will now detect these residual tables, throw an error, and halt the startup as intended.
Problem:
On some clones, we perform data deletion after cloning. If a query fails, the instance shuts down. If the process is restarted from scratch by f.e. human error, some dependencies might have changed due to the previous interruption. This could result in incomplete data deletion.
Solution:
If the cleanup materialized views already exist at startup, it means a previous execution failed. To prevent data inconsistency, we now raise an exception and stop the process immediately instead of continuing.
Additionally, this improves performance runnin and detecting cloning errors by ensuring we don't trigger slow, redundant deletion processes on inconsistent data.