refactor: extract filter values into variables

[deeonwuli]

📌 References

• Issue: Closes https://app.clickup.com/t/865ctk3vy
• Feat/glass ear report #107 (comment)

📝 Implementation

📹 Screenshots/Screen capture

🔥 Notes to the tester

REACT_APP_REPORT_VARIANT=glass-submission
REACT_APP_DHIS2_BASE_URL=https://dev.eyeseetea.com/who-dev-238/

[reviewpad]

AI-Generated Summary: This pull request contains refactoring changes in the GLASSDataSubmissionDefaultRepository.ts file. The filter values are extracted into their own constants to make the code clearer and more readable. The logical operations inside if-statements are also streamlined and refactored to decrease code complexity. In addition, the conditional statements are revised to introduce consistency and further improve readability. The changes are all structural and do not affect the functionality of the code.

[reviewpad]

Reviewpad Report

‼️ Errors

• Unconventional commit detected: 'Merge branch 'development' into refactor/glass-submission-report-refactor' (52d4d48)

[reviewpad]

AI-Generated Summary: This pull request refactors parts of the GLASSDataSubmissionDefaultRepository.ts file for better readability and maintainability. The conditional logic within the row filtering functions has been extracted into separate variables, providing clearer expressions of the filtering criteria. This change primarily affects the conditionals that were previously within filter method callbacks. Now, instead of conducting checks within these callbacks, the checks are assigned to their respective variables which makes the code easier to understand, debug, and maintain.

[anagperal]

Thanks @deeonwuli !! Now all conditionals are read much better than before 🎉