Replicate MAL approval report for NHWA

[eperedo]

📌 References

• Issue: Closes https://app.clickup.com/t/8699z5d42

📝 Implementation

• Added app settings module for dataSet configuration.
• Add new column for approval status
• Update periods
• Created sql views for Module 1 and 2 (metadata attached in issue)
• Configure permissions for actions: NHWA administrators have access to everything. Only NHWA administrators and NHWA _DATA Capture Module 1/NHWA _DATA Capture Module 2-4 can submit/revoke.

📹 Screenshots/Screen capture

Module 1

approval_report_list.mp4

Module 2

approval_report_module_2.mp4

🔥 Notes to the tester

Do not merge this PR. We should move to its own repo since current version is generic enough to configure any dataSet (through hardcode in source code, but we can add the UI in the future)

#8699z5d42

[Ramon-Jimenez]

Thanks @eperedo , a few things we need to fix:

• I get 409 when trying to approve a Dataset, either when trying to approve single values through Check Difference pop-up, or if I try to approve the whole dataset

• When you get the 409, in fact, the record gets messed up and everything looks like no data at all, even if you had some data there like dates or dataset completed/submitted, etc...

• As of now in DEV EST, if you test with Cameroon 2024 there are some modifications but you cannot perform any contextual action, not complete, submit or approve.

• We should allow applying filters even if no dataset is selected, that way client can have all datasets listed for an specific OrgUnit and Period. Right now the dataset is 'mandatory' for clicking in 'Apply Filters', but it should be optional just like any other filter

• Let's move the 'Approval' filter to the right, so the filters follow the same order as the columns in the list below: Complete - Submit - Approve

• Please, let's also add an additional filter for Modification Count that allows to filter between following two options: 0 | Greater than 0

Thanks!

[Ramon-Jimenez]

Thanks @eperedo . It is now working as desired, although there are a few things that could be a bit confusing to the client and I think we should improve:

• Allow selection of multiple Datasets (pending from last review)

• When you approve values using 'Check differences', there is a loading screen that says 'Approving data values'. We should use that very same screen with some text for the rest of the actions to keep coherence across the whole app, but we aren't doing so. Please, include the loading screen in all actions:

• Complete -> Text should say 'Completing dataset'

• Submit -> Text should say 'Submitting dataset'

• Revoke -> Text should say 'Revoking dataset'

• Approve -> Text should say 'Approving dataset'

• When you close the Check differences pop-up, or you finish any action such as Complete, Submit, Revoke or Approve, we should automatically clear the list in the main page and then load it again. As of now, we are loading the list again but until we finish the loading the old information is printed in the list, which is confusing.

• The button 'Apply filters' should clear and refresh the list even if no change on the filters have been done. Right now, if you don't change any filter, you cannot click on 'Apply filters' to refresh the information, but this should be possible.

• Periods filter option on top says 'all' but it should say '' instead

• Please, remove the Activate monitoring option for now, we can reinclude it when we prepare the generic app but right now it is not an NHWA request and I am not 100% sure it is actually working.

[Ramon-Jimenez]

Thanks @eperedo , some follow-up actions:

• For some reason it doesn't show any contextual action by right-clicking in the row or even in the three dots at the right, which are not there anymore

• Period filter should have a '' at the top (the option is there but is showing '', my fault because I provided wrong feedback on latest PR review, apologies)

I cannot test the new loading screens and list refresh because I don't have access to any actions, but the rest of the requests from last PR review are OK, thanks.