Open
Conversation
ifoche
changed the title
idelcano
changed the title
tokland
reviewed
Apr 4, 2022
src/webapp/reports/validate-custom-forms/ValidateCustomFormsReport.tsx
Outdated
Show resolved
Hide resolved
src/domain/validatecustomforms/repositories/CustomFormErrorsRepository.ts
Outdated
Show resolved
Hide resolved
tokland
reviewed
Apr 4, 2022
src/webapp/reports/validate-custom-forms/ValidateCustomFormsReport.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
We have a false positive in dev: its due we have a piece of old code commented that points Ybz3qUCWYKC to Xr12mI7VPn3, but that dataelement is related with their valid categorycombo in the custom form. |
tokland
approved these changes
May 6, 2022
Contributor
tokland
left a comment
tokland
left a comment
There was a problem hiding this comment.
Code looking very good after the last refactors! Code-wise, it's mergeable by me.
| categoryCombos: { fields: { id: true, categoryOptionCombos: { id: true } } }, | ||
| }); | ||
|
|
||
| const data = await metadata$.getData(); |
| if (groups) { | ||
| return { dataElementId: groups[2], categoryOptionComboId: groups[4] }; | ||
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
map + compact to remove undefined values.
| i18n.t("does not exist in dataset with UID:") + | ||
| " " + | ||
| id | ||
| ); |
Contributor
There was a problem hiding this comment.
i18n.t interpolation with {{ var }}
| @@ -0,0 +1,3 @@ | |||
| export interface DataSetsRepository { | |||
| validate(id: string): Promise<string[]>; | |||
| <Typography variant="h5">{i18n.t("Result:")}</Typography> | ||
| </div> | ||
|
|
||
| {_.map(errors, item => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
🎨 Screenshots
🔥 Notes to the tester
To see some errors you could deassign some dataelements from the modules, and change the categoryoptioncombo of some dataelements