Skip to content

baseline fixes#1

Open
MatiasArriola wants to merge 4 commits intodevelopmentfrom
test/fix-baseline
Open

baseline fixes#1
MatiasArriola wants to merge 4 commits intodevelopmentfrom
test/fix-baseline

Conversation

@MatiasArriola
Copy link
Contributor

@MatiasArriola MatiasArriola commented Mar 12, 2026

📌 References

  • Issue: Closes #?

📝 Implementation

  • Fix Program type labels
  • Fix dataElement mapping previews when selecting more than 1 dataElement
  • Fix OrgUnitTree picker (default selection, changing selection)
  • Add currentDataElement mapping to template

📹 Screenshots/Screen capture

🔥 Notes to the tester

@bundlemon
Copy link

bundlemon bot commented Mar 12, 2026

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
Build Folder
./**/*
889.46KB (+395B +0.04%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the user-facing “friendly” program type labels so UI surfaces (landing page + wizard) show consistent product copy instead of the raw registration wording.

Changes:

  • Update getProgramTypeLabel mapping: WITH_REGISTRATIONTracker Program, WITHOUT_REGISTRATIONEvent Program.
  • Add an OpenSpec archive change set documenting the spec/test alignment work and verification steps.
  • Minor markdown formatting tweak (trailing newline) in the file-export-wizard spec.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/webapp/presenters/programTypeLabel.ts Restores the expected friendly label mapping used by landing page and wizard UI.
openspec/specs/file-export-wizard/spec.md Adds a trailing newline at EOF.
openspec/changes/archive/2026-03-12-fix-failing-tests/tasks.md Documents the tasks performed to restore labels and align assertions.
openspec/changes/archive/2026-03-12-fix-failing-tests/specs/landing-page-components/spec.md Captures modified requirements for landing page friendly labels.
openspec/changes/archive/2026-03-12-fix-failing-tests/specs/file-export-wizard/spec.md Captures modified requirements for wizard friendly labels.
openspec/changes/archive/2026-03-12-fix-failing-tests/proposal.md Records rationale/scope/impact for restoring the label contract.
openspec/changes/archive/2026-03-12-fix-failing-tests/design.md Records decisions, risks, and rollout/rollback approach for the change.
openspec/changes/archive/2026-03-12-fix-failing-tests/.openspec.yaml Adds OpenSpec metadata for the archived change set.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  - Derive selectedPaths from prop via useMemo instead of dual
    useState/useEffect, fixing single-click selection
  - Build path map for all hierarchy levels (root, intermediate, leaf)
    so clicking any visible node resolves correctly
  - Select hierarchy root as default org unit instead of arbitrary leaf
  - Add initiallyExpanded to auto-expand tree to default selection
  - Add custom React.memo comparator to prevent re-renders from
    unstable onChange references
@MatiasArriola MatiasArriola changed the title fix(program-type): restore friendly program labels baseline fixes Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants