fix: enforce allowlist enum on transitionType in WebSocket messages (closes #67)#73
Open
LucasMaupin wants to merge 1 commit into
Open
fix: enforce allowlist enum on transitionType in WebSocket messages (closes #67)#73LucasMaupin wants to merge 1 commit into
LucasMaupin wants to merge 1 commit into
Conversation
…loses #67) Replaces the permissive z.string().max(32) validator on transitionType in TRANSITION and TAKE messages with a strict z.enum([...]) containing all valid Strom transition names. Arbitrary strings can no longer reach the Strom pipeline API. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the permissive
z.string().max(32)validator ontransitionTypeinTRANSITIONandTAKEWebSocket messages with a strictz.enum([...])containing all valid Strom transition names.What changed:
TransitionTypeSchema(Zod enum) insrc/ws/controller.tslisting all valid Strom transition typesTRANSITIONmessage:transitionTypenow must be one of the known enum valuesTAKEmessage:transitionType(optional) now must be one of the known enum values when providedArbitrary strings can no longer reach the Strom pipeline API via the WebSocket handler. Any client sending an unrecognised transition type will receive a validation error before the message is forwarded to Strom.
Closes #67