Fix infinite loop when restarting the secondary process #1040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
An infinite loop can occur in the DPDK timer subsystem under the following conditions:
Root cause
The head of the DPDK timer's linked list is located in shared memory, which is managed and owned by the primary process.
When a secondary process restarts, it re-executes its initialization routines, including the one for
freebsd_clock. This routine attempts to add a timer to the linked list. However, since the list already exists and was never cleaned up from the secondary process's perspective, this operation incorrectly links the timer back to itself, creating a cycle in the list. Consequently, any code that subsequently traverses this corrupted list enters an infinite loop.Solution
freebsd_clocktimer is stopped and removed during graceful shutdown.