Python 3.8 - Update _check_keys to avoid Runtime Error when sanitizing response for keywords#1562
Open
oldarmyc wants to merge 1 commit intoF5Networks:developmentfrom
Open
Python 3.8 - Update _check_keys to avoid Runtime Error when sanitizing response for keywords#1562oldarmyc wants to merge 1 commit intoF5Networks:developmentfrom
oldarmyc wants to merge 1 commit intoF5Networks:developmentfrom
Conversation
…ginal to avoid RuntimeError in Python 3.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues: Runtime error sanitizing python keywords from dictionary
Fixes #1561
Problem: In Python 3.8 a Runtime error is thrown when sanitizing python keywords from response dictionary.
Analysis: Changing the iteration to loop through a copy of the response dictionary and update the original, to avoid updating the dictionary while looping through it.
Tests: The following existing tests within bigip/test/unit/test_resource.py cover the proposed changes.
test_Resource__check_keys_python_keyword
test_Resource__check_for_python_keywords
test_Resource__check_for_python_keywords_recursive