Skip to content

FFWEB-3412: Support tab navigation #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rayn93 merged 1 commit into from
Jul 14, 2025
Merged

FFWEB-3412: Support tab navigation #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog
## Unreleased
### Change
- Support tab navigation for search, suggest and paging components

### Fix
- Cart tracking - parse price to float

Expand Down
40 changes: 20 additions & 20 deletions src/view/frontend/templates/ff/paging.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_prev_page.png')) ?>">
</ff-paging-item>

<ff-paging-item type="currentLink -2">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink -1">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink" style="font-weight: bold;">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink +1">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink +2">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink -2"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="currentLink -1"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="currentLink" style="font-weight: bold;"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="currentLink +1"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="currentLink +2"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="nextLink">
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_next_page.png')) ?>">
</ff-paging-item>
Expand All @@ -25,12 +25,12 @@
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_prev_page.png')) ?>">
</ff-paging-item>

<ff-paging-item type="currentLink -2">{{value}}</ff-paging-item>
<ff-paging-item type="currentLink -1">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink" style="font-weight: bold;">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink +1">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink -2"><a href="#">{{value}}</a></ff-paging-item>
<ff-paging-item type="currentLink -1"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="currentLink" style="font-weight: bold;"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="currentLink +1"><a href="#">{{page}}</a></ff-paging-item>
...
<ff-paging-item type="lastLink">{{page}}</ff-paging-item>
<ff-paging-item type="lastLink"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="nextLink">
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_next_page.png')) ?>">
</ff-paging-item>
Expand All @@ -41,13 +41,13 @@
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_prev_page.png')) ?>">
</ff-paging-item>

<ff-paging-item type="firstLink">{{page}}</ff-paging-item>
<ff-paging-item type="firstLink"><a href="#">{{page}}</a></ff-paging-item>
...
<ff-paging-item type="currentLink -1">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink" style="font-weight: bold;">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink +1">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink -1"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="currentLink" style="font-weight: bold;"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="currentLink +1"><a href="#">{{page}}</a></ff-paging-item>
...
<ff-paging-item type="lastLink">{{page}}</ff-paging-item>
<ff-paging-item type="lastLink"><a href="#">{{page}}</a></ff-paging-item>

<ff-paging-item type="nextLink">
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_next_page.png')) ?>">
Expand All @@ -58,12 +58,12 @@
<ff-paging-item type="previousLink">
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_prev_page.png')) ?>">
</ff-paging-item>
<ff-paging-item type="firstLink">{{page}}</ff-paging-item>
<ff-paging-item type="firstLink"><a href="#">{{page}}</a></ff-paging-item>
...
<ff-paging-item type="currentLink -1">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink" style="font-weight: bold;">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink +1">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink +2">{{page}}</ff-paging-item>
<ff-paging-item type="currentLink -1"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="currentLink" style="font-weight: bold;"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="currentLink +1"><a href="#">{{page}}</a></ff-paging-item>
<ff-paging-item type="currentLink +2"><a href="#">{{page}}</a></ff-paging-item>

<ff-paging-item type="nextLink">
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_next_page.png')) ?>">
Expand Down
8 changes: 4 additions & 4 deletions src/view/frontend/templates/ff/suggest.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,21 @@
<div data-container="searchTerm">
<p class="containerCaption"><?= $escaper->escapeHtml(__('Search suggestions')) ?></p>
<ff-suggest-item type="searchTerm">
<span>{{{name}}}</span>
<a href="#">{{{name}}}</a>
</ff-suggest-item>
</div>

<div data-container="category">
<p class="containerCaption"><?= $escaper->escapeHtml(__('Category suggestions')) ?></p>
<ff-suggest-item type="category">
<span>{{{name}}}</span>
<a href="#">{{{name}}}</a>
</ff-suggest-item>
</div>

<div data-container="brand">
<p class="containerCaption"><?= $escaper->escapeHtml(__('Brands')) ?></p>
<ff-suggest-item type="brand">
<span>{{{name}}}</span>
<a href="#">{{{name}}}</a>
</ff-suggest-item>
</div>
</section>
Expand All @@ -38,7 +38,7 @@
<ff-suggest-item type="productName">
<img data-image="{{suggestions.image}}" />
<div class="product-center">
<div class="product-name">{{{name}}}</div>
<a href="#" class="product-name">{{{name}}}</a>
</div>
<div class="product-right">
<div class="product-price">{{attributes.Price}}</div>
Expand Down
Loading