INT-227: Add Query Array Normalizer middleware

.github/workflows/ci.yml

@@ -24,7 +24,7 @@ jobs:
         run: echo "::set-output name=dir::$(composer config cache-files-dir)"
 
       - name: Load Composer cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ${{ steps.composer-cache.outputs.dir }}
           key: ${{ runner.os }}-${{ matrix.php }}-${{ matrix.deps }}-composer

CHANGELOG.md

@@ -1,4 +1,8 @@
 # Changelog
+## Unreleased
+### BREAKING
+- Add QueryArrayNormalizer middleware to ClientBuilder
+
 ## [v0.9.9] - 2024.06.06
 ### Added
 - Add support to API key authorization

composer.json

@@ -28,7 +28,7 @@
   },
   "scripts": {
     "test": [
-      "php-cs-fixer fix --dry-run -v",
+      "php-cs-fixer fix -v",
       "phpmd src text phpmd.xml.dist",
       "phpspec run --format=dot"
     ]

src/Client/ClientBuilder.php

@@ -7,6 +7,7 @@
 use GuzzleHttp\HandlerStack;
 use Omikron\FactFinder\Communication\Client\Middleware\Authenticator;
 use Omikron\FactFinder\Communication\Client\Middleware\HttpErrors;
+use Omikron\FactFinder\Communication\Client\Middleware\QueryArrayNormalizer;
 use Omikron\FactFinder\Communication\Credentials;
 use Omikron\FactFinder\Communication\ServerUrl;
 use Omikron\FactFinder\Communication\Version;
@@ -57,6 +58,7 @@ public function build(): ClientInterface
     {
         $handler = HandlerStack::create();
         $handler->push(new HttpErrors());
+        $handler->push(new QueryArrayNormalizer());
 
         $config = [
             'base_uri'    => $this->serverUrl,

src/Client/Middleware/QueryArrayNormalizer.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Omikron\FactFinder\Communication\Client\Middleware;
+
+use Psr\Http\Message\RequestInterface;
+
+class QueryArrayNormalizer
+{
+    public function __invoke(callable $handler)
+    {
+        return function (RequestInterface $request, array $options) use ($handler) {
+
+            $uri   = $request->getUri();
+            $query = $uri->getQuery();
+
+            if (!$query) {
+                return $handler($request, $options);
+            }
+
+            parse_str($query, $params);
+
+            $normalized = [];
+
+            foreach ($params as $key => $value) {
+                if (is_array($value)) {
+                    foreach ($value as $v) {
+                        $normalized[] = rawurlencode($key) . '=' . rawurlencode((string) $v);
+                    }
+
+                    continue;
+                }
+
+                $normalized[] = rawurlencode($key) . '=' . rawurlencode((string) $value);
+            }
+
+            $newQuery = implode('&', $normalized);
+
+            $request = $request->withUri(
+                $uri->withQuery($newQuery)
+            );
+
+            return $handler($request, $options);
+        };
+    }
+}