Skip to content

Disallow pre-release for uv#147

Merged
ka-sarthak merged 1 commit intomainfrom
disallow-pre-release-uv
Aug 11, 2025
Merged

Disallow pre-release for uv#147
ka-sarthak merged 1 commit intomainfrom
disallow-pre-release-uv

Conversation

@ka-sarthak
Copy link
Copy Markdown
Collaborator

@ka-sarthak ka-sarthak commented Aug 11, 2025

Summary by Sourcery

CI:

  • Remove the "--prerelease=allow" flag from the uv run command in the mkdocs-deploy GitHub Actions workflow

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update the mkdocs-deploy workflow to disallow pre-release versions by removing the --prerelease=allow flag from the uv run command.

File-Level Changes

Change Details Files
Removed pre-release allowance from uv command in deployment workflow
  • Removed --prerelease=allow flag from uv run invocation
.github/workflows/mkdocs-deploy.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ka-sarthak - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ka-sarthak
Copy link
Copy Markdown
Collaborator Author

We (with @DanielYang59) removed the Pydantic constraints in the dev table here, given that it was not being explicitly used in the package: #146. But doing so fails the mkdocs deployment.

I think the constraints were placed to avoid installing pre-release versions of Pydantic in the dev environment. But this would only happen if uv allows pre-release, which we do in mkdocs deploy CI. Do we need the pre-release flag in the first place? @hampusnasstrom, here you allowed the pre-release specifically in #139. Is this still required?

Copy link
Copy Markdown
Collaborator

@hampusnasstrom hampusnasstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was just to get the macro from nomad-lab before it was in a official release. Should be safe to remove.

@ka-sarthak ka-sarthak merged commit a20c7d3 into main Aug 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants