Include the old convension to call nexsu_parser in the aliases list.#776
Merged
Conversation
Closed
Collaborator
|
It looks good, but we need to check it works. I guess we can only find out if we reprocess older data in production (like what was reported in the issue). @lauri-codes that probably solves the issue, right? |
lukaspie
approved these changes
May 8, 2026
Collaborator
Author
Yeah, I logically checked if aliases refer to the correct entry point. |
b3d5858 to
891e845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #773
In some previous version of
pynxtools, we registered the nexus parser in a different way,pynxtools.nomad.entrypoints:nexus_parser. But later changing the entry point name topynxtools.nomad.parsers:nexus_parsercauses an error in nomad. This is fixed by adding the old convention in aliases in NexusParserEntryPoint.I tested if the aliases are registered properly.