fix: accumulate AVX2 and FMA compile flags on avx2 codelets - #409
Open
DiamonDinoia wants to merge 1 commit into
Open
fix: accumulate AVX2 and FMA compile flags on avx2 codelets#409DiamonDinoia wants to merge 1 commit into
DiamonDinoia wants to merge 1 commit into
Conversation
COMPILE_FLAGS is a single-valued property, so the HAVE_FMA block overwrote AVX2_FLAG set by the HAVE_AVX2 block, leaving the avx2 codelets compiled with only -mfma. __AVX2__ was then undefined and the build failed with: simd-avx2-128.h: error: "compiling simd-avx2-128.h without avx2 support" Use set_property(... APPEND_STRING ...) so both -mavx2 and -mfma are applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPILE_FLAGS is a single-valued property, so the HAVE_FMA block overwrote AVX2_FLAG set by the HAVE_AVX2 block, leaving the avx2 codelets compiled with only -mfma. AVX2 was then undefined and the build failed with:
simd-avx2-128.h: error: "compiling simd-avx2-128.h without avx2 support"
Use set_property(... APPEND_STRING ...) so both -mavx2 and -mfma are applied.