Fix stride decrease check for negative strides - #415
Open
haiwenheaven wants to merge 1 commit into
Open
Conversation
Compare strides by magnitude in tensor_strides_decrease, using the signed value as a tie-breaker when magnitudes are equal. This prevents negative strides from selecting the wrong indirect solver and avoids recursion between indirect-before and indirect-transpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #414
This patch fixes an infinite planner recursion triggered by a valid
out-of-place complex DFT layout containing negative strides.
The recursion occurs because
tensor_strides_decreasecompares signedstride values directly. With negative strides, this can select
indirect-beforeinstead ofindirect-after, allowingindirect-beforeandindirect-transposeto repeatedly reconstructeach other's subproblems.