Fix heading recognition in readme processing - #5
Merged
Conversation
Enhanced processing to support CRLF line endings (e.g., on Windows). Update tests to validate handling of Setext headings and CRLF line endings in readme sections.
|
@tschwirt is attempting to deploy a commit to the aks129's projects Team on Vercel. A member of the Team first needs to authorize it. |
aks129
added a commit
that referenced
this pull request
Aug 15, 2026
Tim reported the CRLF bug and said he had fixed it locally and would open a separate pull request. He did, as #5. I fixed it myself and pushed before looking at his branch, which would have meant closing a first contributor's first pull request as already done. That is a bad trade at any time and a worse one here, where the repository still shows a single author. His fix is correct and comes with tests. It makes the heading patterns tolerate a trailing CR rather than changing how the file is split. I would have done it at the split, and that preference is not worth overriding someone who found the bug, diagnosed it, and wrote the tests. This restores readme.ts and drops the duplicate tests so #5 applies cleanly. The terminology fixes in the same commit stay: they are unrelated and his branch does not touch them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Package validationNo package changed in this pull request, so there was nothing to validate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced processing to support CRLF line endings (e.g., on Windows). Update tests to validate handling of Setext headings and CRLF line endings in readme sections.