Conversation
| this.line = new LeaderLine(start, end, this.options) | ||
|
|
||
| // Add event listeners | ||
| const self = this |
There was a problem hiding this comment.
I remove the reference to self as it did not make any difference in the functionality. Let me know if there is concern around this change.
|
Found 1 violations: Reporter: ESLint Unexpected dangling '_' in '_id'. (no-underscore-dangle)
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const self = this | ||
| // the only way to identify current line so far: https://github.com/anseki/leader-line/issues/185 | ||
| const connectionElement = document.querySelector('body>.leader-line:last-of-type') | ||
| this.connectionDomHandle = document.getElementById(`leader-line-${this.line._id}-line-path`).closest('svg.leader-line') |
There was a problem hiding this comment.
Reporter: ESLint
Rule: eslint.rules.no-underscore-dangle
Severity: ERROR
File: src/components/interaction-designer/Connection.vue L144
Unexpected dangling '_' in '_id'. (no-underscore-dangle)
bzabos
left a comment
bzabos
left a comment
There was a problem hiding this comment.
@poojahpatil90 this looks good! I left a couple minor comments that I'll leave up to your discretion. Feel welcome to merge if you're happy with what's there!
@poojahpatil90 Can you create a JIRA for this and touch base with @safydy on the details? I don't have a clear answer off the top of my head right now. |
2 participants
@bzabos A question for you - I notice that if we click on a connection and then try hovering over another, we don't have the desired behavior of highlighting the hovered line. I am wondering if we need to make a fix for this as well? Or we can let the user uncheck the selection by clicking outside and then hover over the wires they want to see?