VMO-3261 v091 directory selection expression improvements #29
Conversation
…irectory-selection-block-runner � Conflicts: � package.json
…ality from AdvancedSelectOnePrompt, pending further discussion.
…irectory-selection-block-runner � Conflicts: � package.json
…AdvancedSelectOne Nullable
| validate(selectedRow?: IAdvancedSelectOne[], choiceRows?: string[][]): boolean { | ||
| const {choiceRowFields, isResponseRequired} = this.config | ||
| validate(): boolean { | ||
| // TODO: Decide what to do with this after discussing with Brett |
There was a problem hiding this comment.
This is a revert of Roan's changes since the interface is now different.
Not sure what should happen from here on @AlteaDown
There was a problem hiding this comment.
Yeah, so this is commented out, due to this data existing in a downloaded CSV file, that the flowRunner does not have access to, as it's on whatever downloaded the file. If we wanted to make this work, we would need to provide the Prompt with an interface it can use to use file.
Don't fail build on EsLint.
package.json
Outdated
| { | ||
| "name": "@floip/flow-runner", | ||
| "version": "0.0.94", | ||
| "version": "0.0.95", |
There was a problem hiding this comment.
Once this merges, remember to up the version in flow-block-runners project.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| constructor() {} | ||
|
|
||
| public setProperty(name: string, value: any): IContactProperty { |
There was a problem hiding this comment.
Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/explicit-module-boundary-types
Severity: WARN
File: src/flow-spec/Contact.ts L30
Argument 'value' should be typed with a non-any type. (@typescript-eslint/explicit-module-boundary-types)
| } | ||
| constructor() {} | ||
|
|
||
| public setProperty(name: string, value: any): IContactProperty { |
There was a problem hiding this comment.
Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/no-explicit-any
Severity: WARN
File: src/flow-spec/Contact.ts L30
Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
|
|
||
| export class Contact implements IContact { | ||
| [key: string]: IContactPropertyType | ||
| [key: string]: IContactProperty | ((...args: any[]) => IContactProperty | undefined) | string | undefined |
There was a problem hiding this comment.
Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/no-explicit-any
Severity: WARN
File: src/flow-spec/Contact.ts L24
Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
|
|
||
| import {IContactProperty} from '..' | ||
| import {createFormattedDate} from '../domain/DateFormat' | ||
| import { createFormattedDate } from '../domain/DateFormat' |
There was a problem hiding this comment.
Reporter: ESLint
Rule: eslint.rules.prettier/prettier
Severity: ERROR
File: src/flow-spec/ContactProperty.ts L21
Replace `·createFormattedDate·` with `createFormattedDate` (prettier/prettier)
|
|
||
| import {IContactProperty} from '..' | ||
| import {createFormattedDate} from '../domain/DateFormat' | ||
| import { createFormattedDate } from '../domain/DateFormat' |
There was a problem hiding this comment.
Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/flow-spec/ContactProperty.ts L21
There should be no space after '{'. (object-curly-spacing)
|
|
||
| import {IContactProperty} from '..' | ||
| import {createFormattedDate} from '../domain/DateFormat' | ||
| import { createFormattedDate } from '../domain/DateFormat' |
There was a problem hiding this comment.
Reporter: ESLint
Rule: eslint.rules.object-curly-spacing
Severity: ERROR
File: src/flow-spec/ContactProperty.ts L21
There should be no space before '}'. (object-curly-spacing)
|
Found 38 violations: Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Do not use property shorthand syntax (lodash/prop-shorthand)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)
Reporter: ESLint Do not use property shorthand syntax (lodash/prop-shorthand)
Reporter: ESLint Skipped test suite (jest/no-disabled-tests)
Reporter: ESLint Avoid referencing unbound methods which may cause unintentional scoping of `this`. (@typescript-eslint/unbound-method)
Reporter: ESLint This line has a length of 146. Maximum allowed is 140. (max-len)
Reporter: ESLint This line has a length of 166. Maximum allowed is 140. (max-len)
Reporter: ESLint This line has a length of 157. Maximum allowed is 140. (max-len)
Reporter: ESLint This line has a length of 181. Maximum allowed is 140. (max-len)
Reporter: ESLint Skipped test suite (jest/no-disabled-tests)
Reporter: ESLint Do not use "// @ts-ignore" because it alters compilation errors. (@typescript-eslint/ban-ts-comment)
Reporter: ESLint Argument 'value' should be typed with a non-any type. (@typescript-eslint/explicit-module-boundary-types)
Reporter: ESLint Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
Reporter: ESLint Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
Reporter: ESLint Replace `·createFormattedDate·` with `createFormattedDate` (prettier/prettier)
Reporter: ESLint There should be no space after '{'. (object-curly-spacing)
Reporter: ESLint There should be no space before '}'. (object-curly-spacing)
Reporter: ESLint Expected comment to be above code. (line-comment-position)
Reporter: ESLint Expected comment to be above code. (line-comment-position)
Reporter: ESLint Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
Reporter: ESLint Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
Reporter: ESLint Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
Reporter: ESLint Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)
|
| validate(selectedRow?: IAdvancedSelectOne[], choiceRows?: string[][]): boolean { | ||
| const {choiceRowFields, isResponseRequired} = this.config | ||
| validate(): boolean { | ||
| // TODO: Decide what to do with this after discussing with Brett |
There was a problem hiding this comment.
Yeah, so this is commented out, due to this data existing in a downloaded CSV file, that the flowRunner does not have access to, as it's on whatever downloaded the file. If we wanted to make this work, we would need to provide the Prompt with an interface it can use to use file.
No description provided.