Skip to content

(#198)Added ReadMore feature to Designers#209

Open
saarthakchats wants to merge 1 commit into
FOSSASIA-Web:gh-pagesfrom
saarthakchats:gh-pages
Open

(#198)Added ReadMore feature to Designers#209
saarthakchats wants to merge 1 commit into
FOSSASIA-Web:gh-pagesfrom
saarthakchats:gh-pages

Conversation

@saarthakchats

@saarthakchats saarthakchats commented Dec 10, 2018

Copy link
Copy Markdown
Contributor

Added feature that improves look and style of the designers' section(also saves space-- temporarily)
Fixes #198
Preview Link

Before

screenshot 2018-12-05 at 11 51 28 am

After

screenshot 2018-12-10 at 8 29 44 am

screenshot 2018-12-10 at 8 29 44 am

@saarthakchats

saarthakchats commented Dec 10, 2018

Copy link
Copy Markdown
Contributor Author

I understand that this might not be the most effiecient way to do this but after trying out 3-4 methods, this for me is the only reliable way through which the function works perfectly.
Please review and merge.. thanks 😄

@abishekvashok abishekvashok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a single function with parameters. Reliability would be the same.

@saarthakchats

Copy link
Copy Markdown
Contributor Author

I tried earlier, but it doesn't work for me.. a lot of problems were occuring

@saarthakchats saarthakchats force-pushed the gh-pages branch 2 times, most recently from 5fdcfe5 to 3660574 Compare December 10, 2018 05:32
@saarthakchats

Copy link
Copy Markdown
Contributor Author

Done @abishekvashok
It finally did work for me 👍

Comment thread index.html
Software projects such as the Scribus desktop publishing software. He is
projectleader
of FontMatrix, a font management system initiated in 2007. He works on the duo
of FontMatrix, a font management system initiated in<span id="dots1">...</span><span id="more1"> 2007. He works on the duo

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abishekvashok abishekvashok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider the comment by @pythongiant

Comment thread js/custom.js

} else if (number == 3) {
var dots = document.getElementById("dots3");
var moreText = document.getElementById("more3");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Append the number to the IDs and reduce the ifs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, I failed terribly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't fail, please do it correctly.

@saarthakchats

Copy link
Copy Markdown
Contributor Author

@pythongiant I'm using the 'dots' as id to pull so I can do without the ellipsis

@pythongiant

Copy link
Copy Markdown
Contributor

That is just more complicated and not required. moreover, it slows the website.

@pythongiant I'm using the 'dots' as id to pull so I can do without the ellipsis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants