Skip to content

[WIP] WIP address feedback on graph nodes fetching script test#4

Closed
Copilot wants to merge 1 commit intofeature/add_fetch_perdecade_datafrom
copilot/sub-pr-3
Closed

[WIP] WIP address feedback on graph nodes fetching script test#4
Copilot wants to merge 1 commit intofeature/add_fetch_perdecade_datafrom
copilot/sub-pr-3

Conversation

Copy link
Contributor

Copilot AI commented Nov 17, 2025

Thanks for the feedback on #3. I've created this new PR, which merges into #3, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #3
Triggering review: #3 (comment)

@copilot it was a mistake. I changed it to the actual test I wanted (that is, in_decade_references contains all the referenced works that are in oa_ids).

assert (
                set(referenced_works)
                .intersection(oa_ids)
                .issubset(set(in_decade_references))
            )

What do you think?


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants