Skip to content

Remove util.TraceEntityHull warning#186

Merged
FPtje merged 2 commits into
FPtje:masterfrom
Astralcircle:patch-1
Apr 18, 2026
Merged

Remove util.TraceEntityHull warning#186
FPtje merged 2 commits into
FPtje:masterfrom
Astralcircle:patch-1

Conversation

@Astralcircle

Copy link
Copy Markdown
Contributor

This function is not broken and works completely fine, i don't understand why you marked it as broken

@FPtje

FPtje commented Apr 16, 2026

Copy link
Copy Markdown
Owner

Good question, probably should have documented that better 😅

@Astralcircle

Astralcircle commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

Perhaps you added this because you initially used the function incorrectly and thought it was broken? Or did you add it a long time ago when it was actually broken? idk

@FPtje

FPtje commented Apr 16, 2026

Copy link
Copy Markdown
Owner

Probably the latter I think

@FPtje

FPtje commented Apr 18, 2026

Copy link
Copy Markdown
Owner

I did some searching. The code to check for that function has changed many many times, migrated between many different files as well, but the initial creation commit is ba8624e. The commit text is

All functions from http://wiki.garrysmod.com/page/Category:Deprecated_Functions

That page no longer exist, but this wayback snapshot shows the function in that list:

https://web.archive.org/web/20140903092339/http://wiki.garrysmod.com/page/Category:Deprecated_Functions

See this page as well: https://web.archive.org/web/20141224141811/http://wiki.garrysmod.com/page/util/TraceEntityHull

This function is deprecated.
You should avoid using it as it may be removed in a future version.
This function is broken and returns the same values all the time

I suppose it may have gotten fixed in the meantime, and the decision to remove in a future version reverted.

@FPtje

FPtje commented Apr 18, 2026

Copy link
Copy Markdown
Owner

Yeah, the current page mentions nothing about broken or deprecated 👍

This function is not broken and works completely fine, i don't understand why you marked it as broken
@FPtje

FPtje commented Apr 18, 2026

Copy link
Copy Markdown
Owner

Rebased on master to fix the failing CI

@FPtje FPtje merged commit a807392 into FPtje:master Apr 18, 2026
1 check passed
@FPtje

FPtje commented Apr 18, 2026

Copy link
Copy Markdown
Owner

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants