Color indication of auto align failure/success#292
Open
Conversation
Levercpu
requested review from
MikeKantrowitz,
armadilloz,
batchen1,
bengold22 and
noahheller
as code owners
Contributor
Author
|
@goatfanboi23 this is meant to let the drive team know if auto align fails or succeeds as they currently don't always have an easy way to know if they are aligned. |
Contributor
|
We can approach that problem once we get the align working lol.for now that unit tests are for us (the programmers) to validate our code. |
Levercpu
changed the title
Levercpu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.