linted main alongside updating all vendordeps and wpilib.#297
Open
linted main alongside updating all vendordeps and wpilib.#297
Conversation
Levercpu
requested review from
MikeKantrowitz,
armadilloz,
batchen1,
bengold22 and
noahheller
as code owners
noahheller
suggested changes
Mar 25, 2025
| encoderSim.setPositionConversionFactor(1.0); | ||
| config = new SparkMaxConfig(); | ||
| config.encoder.positionConversionFactor(1.0); | ||
| motor.configure(config, null, null); |
Contributor
There was a problem hiding this comment.
was this supposed to be added?
Contributor
Author
There was a problem hiding this comment.
the method .setpositionconversionfactor doesnt not exist for encoder sim anymore, so yes.
Contributor
|
I have updated wpilib into main. We do not want to update other vendor dependencies this close to competition. |
Contributor
Author
|
so, should i close this pr @bengold22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.