You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure how this PR will work together with PR#17, since there you also included some of the changes here. I'll accept that one first, and then I see how this one will work.
Ok, seems to work fine. I have also pushed some internal commit that I had done in the last days. I may have done something wrong, as git is giving me some weird messages, but it seems to work anyway.
About this PR, I have mixed feelings about both things here: adding the Warning log (which may be annoying if someone is running by hand) and another option for the standalone_link (which is another option in the configuration for people to understand, which I always try to avoid), but I see that they may be useful and I don't have any better suggestions. So I'll accept and merge the PR and we can always think on improvements later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
In PR #16, I forgot to include the Font Awesome CDN. Jureptool should now have an alternative for all JS libraries.
Moreover, I added a warning message that is shown when no config folder is provided and the default one is used (which is related to JURI).