Skip to content

Node 16#4

Merged
martindale merged 43 commits into
masterfrom
feature/node-16
Apr 28, 2026
Merged

Node 16#4
martindale merged 43 commits into
masterfrom
feature/node-16

Conversation

@martindale
Copy link
Copy Markdown
Member

@martindale martindale commented Jun 9, 2022

All changes to master — wait for #3

Summary by CodeRabbit

  • New Features

    • Identity management interface with password derivation and validation
    • Remote connection bridge component with messaging support
    • Seed phrase entry workflow
  • Documentation

    • Added developer guide with code examples
    • Updated README with quick start guide
  • Tests

    • Introduced automated test suite with GitHub Actions CI/CD pipeline
  • Chores

    • Updated Node.js runtime requirement to v24.x
    • Added build and coverage reporting scripts
    • Configured ESM module support

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: 34e40701-ed58-4bf1-8a36-d15c84013712

📥 Commits

Reviewing files that changed from the base of the PR and between f0ba77f and 14545e0.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • reports/install.log is excluded by !**/*.log
📒 Files selected for processing (22)
  • .github/workflows/test.yaml
  • .gitignore
  • .nvmrc
  • DEVELOPERS.md
  • README.md
  • assets/bundles/browser.js
  • assets/fabric.react.js
  • assets/index.html
  • components/FabricBridge.js
  • components/FabricIdentity.js
  • components/FabricIdentityManager.js
  • components/IdentityPicker.js
  • components/SeedEntryForm.js
  • components/interface.js
  • package.json
  • scripts/browser.js
  • scripts/build.js
  • settings/state.js
  • tests/fabric.react.js
  • types/component.js
  • types/fabric.js
  • types/spa.js

📝 Walkthrough

Walkthrough

This PR establishes a complete React package infrastructure with CI/CD workflows, multiple React components for identity and fabric bridge management, type definitions, build scripts, ESM configuration, and asset bundling—setting up a production-ready @fabric/react package.

Changes

Cohort / File(s) Summary
CI/CD & Configuration
.github/workflows/test.yaml, .nvmrc, .gitignore
Introduces GitHub Actions test workflow for multi-OS Node testing with coverage upload to Codecov, specifies Node v16.17.1 runtime via .nvmrc, and extends .gitignore to exclude .DS_Store files.
Documentation
README.md, DEVELOPERS.md
Updates README to reflect @fabric/react package branding and adds Quick Start React component example; introduces new DEVELOPERS.md with minimal usage guidance.
React Components
components/FabricBridge.js, components/FabricIdentityManager.js, components/IdentityPicker.js, components/SeedEntryForm.js
Adds four new React class components: FabricBridge for remote client connection management with messaging UI, FabricIdentityManager for identity CRUD with password validation, IdentityPicker for seed generation/restore workflows, and SeedEntryForm for BIP39 seed phrase entry.
Identity Component Refactoring
components/FabricIdentity.js
Migrates from custom FabricComponent base to React's Component, replaces lodash merging with Object.assign, and integrates @fabric/core/types/identity for identity state initialization.
Interface & Asset Files
components/interface.js, assets/bundles/browser.js, assets/index.html, assets/fabric.react.js
Adds Interface component extending @fabric/http Site for HTML generation, introduces webpack bootstrap scaffolding, creates HTML entry point with data bindings, and bundles compiled React code (~2600 lines).
Type Definitions
types/fabric.js, types/spa.js, types/component.js
Introduces Fabric class as main package export with factory methods, adds ReactSPA actor type with JSX rendering and path routing, and modifies component imports (removes EC elliptic, comments out Actor).
Build & Script Infrastructure
scripts/build.js, scripts/browser.js
Adds build script configuring webpack compiler with Babel/CSS Modules for asset generation, and browser entry point that registers Fabric globally and logs initialization.
Package Configuration
package.json, settings/state.js
Updates main entrypoint to types/fabric.js, enables ESM mode, raises Node requirement to 24.x, shifts @fabric/core/@fabric/http to peer dependencies, adds build/coverage/test scripts, and replaces core dependency with elliptic/rollup.
Tests
tests/fabric.react.js
Introduces Mocha test suite that validates package metadata can be imported at runtime.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Poem

🐰 Hop and bundle, weave and thread,
React components, freshly spread!
From bridges built to identities sown,
A Fabric of React has grown and grown!


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@martindale martindale merged commit c913dc4 into master Apr 28, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants