Fix references so they account for inheritance correctly - #159
Draft
PiTheGuy wants to merge 3 commits into
Draft
Conversation
Member
|
Please can you explain the changes here, I am struggling to understand what has changed/what this is fixing. I dont see how this can work when split across many isolated workers. |
Contributor
Author
|
The idea is to split the finding of references into a separate pass so it can use member to data to normalize the references to the class the methods are actually defined. As to how this works with multiple workers, it doesn't. I tested this before I submitted the PR, but I think I just got lucky with the workers were split up. I'm converting this to a draft while I figure the best way to fix this. |
PiTheGuy
marked this pull request as draft
July 21, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148