Skip to content

Fix references so they account for inheritance correctly - #159

Draft
PiTheGuy wants to merge 3 commits into
FabricMC:mainfrom
PiTheGuy:fix-references
Draft

Fix references so they account for inheritance correctly#159
PiTheGuy wants to merge 3 commits into
FabricMC:mainfrom
PiTheGuy:fix-references

Conversation

@PiTheGuy

@PiTheGuy PiTheGuy commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #148

@modmuss50

Copy link
Copy Markdown
Member

Please can you explain the changes here, I am struggling to understand what has changed/what this is fixing. I dont see how this can work when split across many isolated workers.

@PiTheGuy

Copy link
Copy Markdown
Contributor Author

The idea is to split the finding of references into a separate pass so it can use member to data to normalize the references to the class the methods are actually defined.

As to how this works with multiple workers, it doesn't. I tested this before I submitted the PR, but I think I just got lucky with the workers were split up. I'm converting this to a draft while I figure the best way to fix this.

@PiTheGuy
PiTheGuy marked this pull request as draft July 21, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't find references for AbstractVillager.addOffersFromTradeSet

2 participants