Skip to content

Downloads With Retry - #168

Open
winsrewu wants to merge 5 commits into
FabricMC:mainfrom
winsrewu:feat/enhancement_166
Open

Downloads With Retry#168
winsrewu wants to merge 5 commits into
FabricMC:mainfrom
winsrewu:feat/enhancement_166

Conversation

@winsrewu

Copy link
Copy Markdown

Fix #166

@modmuss50

Copy link
Copy Markdown
Member

Is this something you see often? I dont think ive ever had a download failuire?

Comment thread src/logic/MinecraftApi.ts Outdated
Comment thread src/ui/ProgressModal.tsx Outdated
Comment thread src/utils/Progress.ts Outdated
Comment thread src/ui/ProgressModal.tsx
@winsrewu

Copy link
Copy Markdown
Author

Is this something you see often? I dont think ive ever had a download failuire?

Yes for me, and I believe https://github.com/FabricMC/mcsrc/actions/runs/29642171463/job/88359954833 is due to failed fetches.

@modmuss50

Copy link
Copy Markdown
Member

I dont see any network request failuires in that run, im unsure what really happened. It may be caused by having 2 downloads at the same time? Im unsure

@winsrewu

winsrewu commented Jul 28, 2026

Copy link
Copy Markdown
Author

I dont see any network request failuires in that run, im unsure what really happened. It may be caused by having 2 downloads at the same time? Im unsure

The download failed, it's silent, and the page is not ready, so the click is blocked.

(I believe, and it's really lucky to fail 4 times whatever)

(Turns out it's not fetch failure)

@winsrewu
winsrewu requested a review from modmuss50 July 28, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Download with retry

2 participants