Clarify ShaderGraph variable renaming for Material API access#32
Open
0xTas wants to merge 2 commits into
Open
Conversation
Member
|
I don't want to accept this because I feel like we should fix this. |
Author
|
Fair, I can open an issue on the engine repo if you'd like? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a warning to the ShaderGraph Variables docs explaining that variable names can be changed during shader compilation. This caused me a lot of confusion when trying to access them via Material.Set() etc. since the name used in code did not match what was set and shown in ShaderGraph (e.g. "Intensity" → "g_fIntensity").
Also includes an example and points readers to the generated .shader file so they can find the correct compiled name for their variables.