-
Notifications
You must be signed in to change notification settings - Fork 2
Remove askpraxis default from CLI #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -230,9 +230,8 @@ Act on it: | |
| raptor command: ` + "`FACETS_PROFILE=<profile> raptor …`" + `. Per-command | ||
| prefix, never ` + "`export`" + ` — each shell call starts fresh. | ||
| - ` + "`matches_praxis_url: false`" + ` — raptor targets a different control | ||
| plane than this praxis profile. Expected when praxis points at | ||
| askpraxis.ai (no raptor CP matches it). Otherwise say which two hosts | ||
| you see and ask the user which is intended BEFORE any raptor write; | ||
| plane than this praxis profile. Say which two hosts you see and ask the | ||
| user which is intended BEFORE any raptor write; | ||
|
Comment on lines
+233
to
+234
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win Align both generated guidance paths with the
📍 Affects 2 files
🤖 Prompt for AI Agents |
||
| read-only exploration may proceed with a note. | ||
| - ` + "`installed: false`" + ` — raptor isn't on this machine at all, so every | ||
| control-plane command will fail. The block carries an | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Handle fixture setup errors instead of discarding them.
Put,os.UserHomeDir, andos.ReadFileerrors are ignored in this modified test block. A setup failure can produce a misleading assertion or read the wrong file. Check each error and include the operation and error value in the failure.As per coding guidelines, tests must assert error types or contents rather than only
err != nil.🤖 Prompt for AI Agents
Source: Coding guidelines