🧹 Code Health Improvement: Fix bare except pass in labelstudio_manager.py - #2
🧹 Code Health Improvement: Fix bare except pass in labelstudio_manager.py#2FadelMamar wants to merge 1 commit into
Conversation
Co-authored-by: FadelMamar <52602628+FadelMamar@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Replaced the bare
except Exception: passblock insrc/wildetect/core/visualization/labelstudio_manager.pywith anexcept Exception as e:block that explicitly logs the error usinglogger.error().💡 Why: Silently swallowing broad exceptions ("bare except pass") is an anti-pattern that obscures errors, making it difficult to debug issues if an upload fails. Logging the exception preserves execution flow while surfacing actionable error details, greatly improving the code's maintainability and the system's observability.
✅ Verification: Verified the code syntax locally and successfully ran the test suite using
tests/run_all_tests.pyto ensure no unexpected regressions or regressions to other parts of the codebase were introduced.✨ Result: Improved code health and safer, more observable exception handling during Label Studio detections upload.
PR created automatically by Jules for task 17818920888550217311 started by @FadelMamar