Merged
Conversation
jonasmartin
reviewed
Dec 2, 2025
| Option<SectionDefinition>, // register sections | ||
| Option<SectionDefinition>, // code sections | ||
| ), | ||
| Halt { |
Collaborator
There was a problem hiding this comment.
Good decision to move from tuples to structs
jonasmartin
reviewed
Dec 2, 2025
| let last_step = stack.define(16, "prover_last_step"); | ||
| let conflict_step = stack.define(16, "prover_conflict_step_tk"); | ||
| let read_1 = stack.define(8, "prover_read_1_value"); | ||
| // technically we don't need to check the status code since execute_step will fail if we call a halt without success |
Collaborator
There was a problem hiding this comment.
agree, but very subtle, best to keep validation
jonasmartin
reviewed
Dec 2, 2025
| @@ -182,22 +184,33 @@ pub fn program_counter_challenge(stack: &mut StackTracker) { | |||
| // WOTS_PROVER_FINAL_STEP:16 == WOTS_PROVER_TRACE_STEP:16 && ( WOTS_PROVER_READ_VALUE_1:8 | WOTS_PROVER_READ_VALUE_2:8 | WOTS_PROVER_OPCODE:8 != 93 | 0 | 115 ) | |||
Collaborator
There was a problem hiding this comment.
please adjust this comments with the logic changes. I see the hash comparison added
jonasmartin
reviewed
Dec 4, 2025
| shift(stack, &tables.rshift, BITS_NIBBLE - right_size); | ||
| } | ||
|
|
||
| pub fn var_to_decisions_in_altstack( |
Collaborator
There was a problem hiding this comment.
add comments of the logic
jonasmartin
reviewed
Dec 4, 2025
| } | ||
|
|
||
| #[test] | ||
| fn test_var_to_decisions_in_altstack() { |
Collaborator
There was a problem hiding this comment.
add edge case tests. 64 bits step, 0 step, max nary, 0 last round, etc
jonasmartin
approved these changes
Dec 19, 2025
Collaborator
jonasmartin
left a comment
jonasmartin
left a comment
There was a problem hiding this comment.
LGTM (some review still pending)
jonasmartin
added a commit
that referenced
this pull request
Dec 19, 2025
This reverts commit 88f0f3d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds translation keys handling, some missing challenges, and small fixes.